[webkit-reviews] review denied: [Bug 45362] Reduce minimum DOMTimer interval : [Attachment 67491] Lower DOMTimer's min interval to 3ms

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Matthew Delaney
<mdelaney at apple.com>'s request for review:
Bug 45362: Reduce minimum DOMTimer interval
https://bugs.webkit.org/show_bug.cgi?id=45362

Attachment 67491: Lower DOMTimer's min interval to 3ms
https://bugs.webkit.org/attachment.cgi?id=67491&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 67395)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,18 @@
> +2010-09-13  Matthew Delaney	<mdelaney at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Reduce Safari DOMTimer interval
> +	   https://bugs.webkit.org/show_bug.cgi?id=45362
> +
> +	   * WebCore.exp.in:
> +	   * WebCore.xcodeproj/project.pbxproj:
> +	   * page/DOMTimer.cpp: Deleted obsolete comments.
> +	   * page/DOMTimer.h: Deleted obsolte comments.
> +	   * page/DOMTimerSettings.cpp: Added. Exposes function to set the
DOMTimer's minInterval.
> +	   (WebCore::setMinTimerIntervalSetting):
> +	   * page/DOMTimerSettings.h: Added.

Why not just do this through WebCore::Settings?


> Index: WebKit2/WebKit2.xcodeproj/project.pbxproj
> ===================================================================
> --- WebKit2/WebKit2.xcodeproj/project.pbxproj (revision 67395)
> +++ WebKit2/WebKit2.xcodeproj/project.pbxproj (working copy)
> @@ -1680,6 +1680,7 @@
>			isa = PBXProject;
>			buildConfigurationList = 1DEB91B108733DA50010E9CD /*
Build configuration list for PBXProject "WebKit2" */;
>			compatibilityVersion = "Xcode 3.1";
> +			developmentRegion = English;
>			hasScannedForEncodings = 1;
>			knownRegions = (
>				English,

Please don't include this project change in any of the diffs.

r- for the 3 vs. 4ms thing.