[webkit-reviews] review requested: [Bug 45381] [Gtk] Adjust atk_text_get_text_at_offset to account for bullets/numbers in list items : [Attachment 67807] Patch proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 45381: [Gtk] Adjust atk_text_get_text_at_offset to account for
bullets/numbers in list items
https://bugs.webkit.org/show_bug.cgi?id=45381

Attachment 67807: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=67807&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Attaching a patch that would fix the issue.

It adds some -pretty simple yet useful- new API to WebCore::RenderListMarker
and WebCore::RenderListItem to provide a way to retrieve the actual full text
involved in a list item, that is, the item marker (like "1", from "1. This is
an item") and the item marker's suffix (like ". " in "1. This is an item"). So
far, it was possible to retrieve the marker but not the suffix, which was
dinamically calculated and drawn in the paint() method of
WebCore::RenderListMarker. However, as we need the suffix to be as much as
accurate as possible when exposing list items to AT's through the ATK
implementation (GTK), we need a way to get that suffix as well, and I thought
of this one as the best way to do it.

The other part of the patch is just in AccessibilityObjectWrapperAtk.cpp (GTK
port) and fixes some problems considering list markers in the AtkText interface
implementation, now doing it in a more consistent way, IMHO.

Hence, now asking for review.