[webkit-reviews] review granted: [Bug 45737] [Chromium] fast/frames/frame-limit.html is crashing on debug bots after r67179:r67353 roll : [Attachment 67789] Proposed patch.

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 45737: [Chromium] fast/frames/frame-limit.html is crashing on debug bots
after r67179:r67353 roll
https://bugs.webkit.org/show_bug.cgi?id=45737

Attachment 67789: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=67789&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67789&action=prettypatch

> WebCore/html/HTMLFrameOwnerElement.cpp:57
> +	   RefPtr<Frame> protect(frame);

Aw crap, frameDetached calls FrameLoader::detachFromParent(), which in turn may
destroy the frame. Good catch. 

I see that this is necessary, I just don't like that we have to double-protect
it (once here and once in detachFromParent). I also don't like that we end up
calling disconnectedOwnerElement twice in such cases.