[webkit-reviews] review granted: [Bug 45887] Web Inspector: move resourceTracking flag under control of BackendSettings : [Attachment 67794] [patch] initial version.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 45887: Web Inspector: move resourceTracking flag under control of
BackendSettings
https://bugs.webkit.org/show_bug.cgi?id=45887

Attachment 67794: [patch] initial version.
https://bugs.webkit.org/attachment.cgi?id=67794&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67794&action=prettypatch

> LayoutTests/http/tests/inspector/inspector-test2.js:103
> +    WebInspector.panels.resources._toggleResourceTracking();

Please check that current state is "enabled"

> LayoutTests/http/tests/inspector/resource-parameters.html:-36
> -	   InspectorBackend.enableResourceTracking(false);

This test should be refactored to use inspector-test2.js It can be done in a
separate change though.

> WebCore/inspector/InspectorController.cpp:1128
> +    if (m_resourceTrackingEnabled == enable)

I think we may safely remove this if.

> WebKit/chromium/src/WebDevToolsAgentImpl.cpp:261
> +	   ic->setResourceTracking(value == "true" ? true : false);

May be just value == "true"