[webkit-reviews] review denied: [Bug 45520] Add shader generator and cache for GPU accelerated path rendering : [Attachment 67468] Revised patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Sep 16 06:09:48 PDT 2010


Chris Marrin <cmarrin at apple.com> has denied Kenneth Russell <kbr at google.com>'s
request for review:
Bug 45520: Add shader generator and cache for GPU accelerated path rendering
https://bugs.webkit.org/show_bug.cgi?id=45520

Attachment 67468: Revised patch
https://bugs.webkit.org/attachment.cgi?id=67468&action=review

------- Additional Comments from Chris Marrin <cmarrin at apple.com>
But I believe the original point is still valid. Checking in a fix with the
intention of "fixing it" in the misty future is bad practice. If the current
functionality is deficient and needs to be updated to accommodate your new
functionality, you should file a bug for that work, block this one on that, fix
that bug and then land this patch.


More information about the webkit-reviews mailing list