[webkit-reviews] review granted: [Bug 45369] Need to check the target frame and restore the right gesture state during the asynchronous history navigation : [Attachment 67396] patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 15 17:57:02 PDT 2010


Adam Barth <abarth at webkit.org> has granted Johnny Ding <jnd at chromium.org>'s
request for review:
Bug 45369: Need to check the target frame and restore the right gesture state
during the asynchronous history navigation
https://bugs.webkit.org/show_bug.cgi?id=45369

Attachment 67396: patch v2
https://bugs.webkit.org/attachment.cgi?id=67396&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67396&action=prettypatch

> WebCore/loader/RedirectScheduler.cpp:355
> +	   // History reload uses the base target as target frame.
> +	   Frame* targetFrame =
m_frame->tree()->find(m_frame->document()->baseTarget());
> +	   if (!targetFrame && !DOMWindow::allowPopUp(m_frame) &&
!isUserGesture)
> +	       return;

Is there a race condition where the target frame changes between when the
navigation is scheduled and when it fires?


More information about the webkit-reviews mailing list