[webkit-reviews] review granted: [Bug 42336] Add script to synchronize WebKit and Khronos WebGL tests : [Attachment 66785] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 42336: Add script to synchronize WebKit and Khronos WebGL tests
https://bugs.webkit.org/show_bug.cgi?id=42336

Attachment 66785: Patch
https://bugs.webkit.org/attachment.cgi?id=66785&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66785&action=prettypatch

I think this basically looks fine and since there haven't been any updates on
the bug from the original reviewer for a week I'm marking it r+ since we need
this script to incorporate more layout tests from the Khronos site.

>
WebKitTools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py:151

> +    elif (os.path.isdir(in_name)):
According to the previous review this shouldn't have parentheses.