[webkit-reviews] review granted: [Bug 44709] deduplicate-tests should be runnable from any WebKit directory : [Attachment 67259] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 44709: deduplicate-tests should be runnable from any WebKit directory
https://bugs.webkit.org/show_bug.cgi?id=44709

Attachment 67259: Patch
https://bugs.webkit.org/attachment.cgi?id=67259&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67259&action=prettypatch

Looks fine, but I think you want to cache find_checkout_root()

> WebKitTools/Scripts/webkitpy/layout_tests/deduplicate_tests.py:111
> +	       cwd=scm.find_checkout_root())
find_checkout_root is kinda expensive (hits the disk).	Maybe your object
shoudl cache it somewhere?  If this was an actual Command object with a
tool.scm, you would just grab tool.scm.checkout_root. :(   Bug 45838 is kinda
blocking nice non-webkit-patch webkitpy development in this way.