[webkit-reviews] review granted: [Bug 45853] Add queue start/stop messages : [Attachment 67742] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 45853: Add queue start/stop messages
https://bugs.webkit.org/show_bug.cgi?id=45853

Attachment 67742: Patch
https://bugs.webkit.org/attachment.cgi?id=67742&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67742&action=prettypatch

> WebKitTools/Scripts/webkitpy/tool/bot/queueengine.py:-36
> -from webkitpy.common.net.statusserver import StatusServer

Nice.

> WebKitTools/Scripts/webkitpy/tool/bot/queueengine_unittest.py:177
> +    def test_terminating_error(self):
> +	   self._test_terminating_queue(KeyboardInterrupt(), "User terminated
queue.")
> +	   self._test_terminating_queue(TerminateQueue(), "TerminateQueue
exception received.")

These could be separate tests.