[webkit-reviews] review granted: [Bug 45835] Fix incorrect usage of dissolveDragImageToFraction : [Attachment 67728] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Sep 15 15:39:34 PDT 2010
Tony Chang <tony at chromium.org> has granted Daniel Cheng <dcheng at chromium.org>'s
request for review:
Bug 45835: Fix incorrect usage of dissolveDragImageToFraction
https://bugs.webkit.org/show_bug.cgi?id=45835
Attachment 67728: Patch
https://bugs.webkit.org/attachment.cgi?id=67728&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67728&action=prettypatch
> WebCore/ChangeLog:16
> + * manual-tests/selection-drag-crash.html: Added.
Please add a comment saying why this doesn't repro in DRT or test_shell.
> WebCore/manual-tests/selection-drag-crash.html:6
> +function selectText() {
> + window.getSelection().selectAllChildren(document.body);
> +};
Nit: The semi-colon at the end of the test is not needed.
More information about the webkit-reviews
mailing list