[webkit-reviews] review granted: [Bug 45837] Use free variable analysis to improve activation performance : [Attachment 67715] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 45837: Use free variable analysis to improve activation performance
https://bugs.webkit.org/show_bug.cgi?id=45837

Attachment 67715: Patch
https://bugs.webkit.org/attachment.cgi?id=67715&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
 214	     void useVariable(const Identifier* ident, bool isEval)

Since there's only one caller to this function, and it just compares the
property name to the global eval property name, I think you could remove the
isEval flag and have this function compute it automatically.

 220	     void collectFreeVariables(Scope* oldScope, bool
shouldTrackCapturedVariables)

I think this would be clearer if you named "oldScope" "nestedScope" instead.

Might be worth a comment defining what a "captured" variable is.

r=me