[webkit-reviews] review granted: [Bug 44715] maps.google.com flips upside down when zooming map using trackpad in WebKit2 on Mac : [Attachment 67704] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 15 14:01:54 PDT 2010


Adam Roben (aroben) <aroben at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 44715: maps.google.com flips upside down when zooming map using trackpad in
WebKit2 on Mac
https://bugs.webkit.org/show_bug.cgi?id=44715

Attachment 67704: Patch
https://bugs.webkit.org/attachment.cgi?id=67704&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67704&action=prettypatch

> WebCore/platform/graphics/mac/GraphicsLayerCA.mm:2220
> -GraphicsLayer::CompositingCoordinatesOrientation
GraphicsLayerCA::defaultContentsOrientation() const
> +GraphicsLayerCA::CompositingCoordinatesOrientation
GraphicsLayerCA::defaultContentsOrientation() const
I don't see anywhere where you add defaultContentsOrientation() to
GraphicsLayerCA's class declaration. Will this break the build?

> WebCore/platform/graphics/win/GraphicsLayerCACF.cpp:457
> +    // FIXME: need this?
> +//	 if (useTiledLayer) {
> +//	     if (GraphicsLayer::compositingCoordinatesOrientation() ==
GraphicsLayer::CompositingCoordinatesBottomUp)
> +//		 m_layer->setContentsGravity(WKCACFLayer::BottomLeft);
> +//	     else
> +//		 m_layer->setContentsGravity(WKCACFLayer::TopLeft);
> +//	 }
Did you mean to leave this in?

r=me


More information about the webkit-reviews mailing list