[webkit-reviews] review granted: [Bug 41292] [V8]When a NPAPI plugin calls NPN_Evaluate to execute script in browser, if the call is initiated by user, allow the popup : [Attachment 67689] patch v3

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Johnny Ding <jnd at chromium.org>'s
request for review:
Bug 41292: [V8]When a NPAPI plugin calls NPN_Evaluate to execute script in
browser, if the call is initiated by user, allow the popup
https://bugs.webkit.org/show_bug.cgi?id=41292

Attachment 67689: patch v3
https://bugs.webkit.org/attachment.cgi?id=67689&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67689&action=prettypatch

This looks good to me, but I'm not an expert on the plugin code.  Might be
worth having a plug-in expert take a look too.

> WebCore/bindings/v8/NPV8Object.cpp:285
> +    ASSERT(frame);
This assert seems unneeded.  We'll crash on the next line anyway.

> WebKit/mac/ChangeLog:9
> +	   execution frame, so WeKit can always get right gesture state on Mac.

WeKit -> WebKit

> WebKit/mac/ChangeLog:10
> +	   From Mac Snow Leopard, the plugin is run under
"WebKitPluginHost,app"
.app ?