[webkit-reviews] review denied: [Bug 45386] Complete index support for IndexedDB : [Attachment 67544] Patch

[bugzilla-daemon at webkit.org]

Jeremy Orlow <jorlow at chromium.org> has denied Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 45386: Complete index support for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=45386

Attachment 67544: Patch
https://bugs.webkit.org/attachment.cgi?id=67544&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
Reviewed with Steve in person.	He had these few comments.  Will fix
momentarily.

View in context:
https://bugs.webkit.org/attachment.cgi?id=67544&action=prettypatch

> WebCore/storage/IDBCursorBackendImpl.cpp:107
> +    if (m_objectCursor)
Need to do something if it's not an object cursor as well.

> WebCore/storage/IDBCursorBackendImpl.h:82
> +    bool m_objectCursor;
m_isSerializedScriptValueCursor would be more clear

> WebCore/storage/IDBIndexBackendImpl.cpp:131
> +    ASSERT((key->type() == IDBKey::StringType) != query.isColumnNull(0));
If we delete these asserts, we don't need to select this stuff above.  It might
be simpler to remove.