[webkit-reviews] review granted: [Bug 45664] Web Inspector: [Resources panel] Timing accuracy. : [Attachment 67653] [PATCH] Rebaselined. Bots, jump in.

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 45664: Web Inspector: [Resources panel] Timing accuracy.
https://bugs.webkit.org/show_bug.cgi?id=45664

Attachment 67653: [PATCH] Rebaselined. Bots, jump in.
https://bugs.webkit.org/attachment.cgi?id=67653&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
Please address the comments before landing.


View in context:
https://bugs.webkit.org/attachment.cgi?id=67653&action=prettypatch

> WebCore/inspector/InspectorController.cpp:1060
> +    resource->endTiming(0);
It might make sense to pass real time here. The timing may be useful in a
scenario where the user checks whether the resource is available and takes
further decision based on its availability.

> WebCore/platform/network/ResourceHandleClient.h:76
> +	   virtual void didFinishLoading(ResourceHandle*, double) { }
Please specify name for the second parameter.

> WebKit/chromium/public/WebURLLoaderClient.h:67
> +    virtual void didFinishLoading(WebURLLoader*, double finishTime) { }
You will get "unused parameter" warning here.

> WebKit/chromium/public/WebURLLoaderClient.h:70
> +    void didFinishLoading(WebURLLoader* loader) { didFinishLoading(loader,
0); }
This should be virtual, otherwise Chromium may break.