[webkit-reviews] review denied: [Bug 45344] Null deref in InlineBox::height() : [Attachment 66917] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Cris Neckar <cdn at chromium.org>'s
request for review:
Bug 45344: Null deref in InlineBox::height()
https://bugs.webkit.org/show_bug.cgi?id=45344

Attachment 66917: Patch
https://bugs.webkit.org/attachment.cgi?id=66917&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66917&action=prettypatch

> WebCore/rendering/InlineBox.cpp:-97
> +    if (!renderer()->style(m_firstLine))
> +	   return 0;
>      if (renderer()->isText())
>	   return m_isText ? renderer()->style(m_firstLine)->font().height() :
0;
> -    if (renderer()->isBox() && parent())
I believe style(m_firstLine) is non-trivial.  Shouldn't we cache it in a local
variable?

    RenderStyle* firstLineStyle() const { return
document()->usesFirstLineRules() ? firstLineStyleSlowCase() : style(); }
    RenderStyle* style(bool firstLine) const { return firstLine ?
firstLineStyle() : style(); }