[webkit-reviews] review denied: [Bug 45573] [chromium] Fix incorrect drag node/selection painting. : [Attachment 67260] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 14 21:19:43 PDT 2010


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Daniel Cheng
<dcheng at chromium.org>'s request for review:
Bug 45573: [chromium] Fix incorrect drag node/selection painting.
https://bugs.webkit.org/show_bug.cgi?id=45573

Attachment 67260: Patch
https://bugs.webkit.org/attachment.cgi?id=67260&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
I think this will do the wrong thing with iframes and compositing. Iframes pull
the paint behavior flags from their parent iframe (see -[WebFrame _drawRect:]
in WebKit.

Rather than paint via the RenderLayer, why not call m_view->paintContents,
which does not intersect with the scrollview's frame?

It would also be nice to share more code here with Mac's
Frame::imageFromRect().


More information about the webkit-reviews mailing list