[webkit-reviews] review canceled: [Bug 45446] [EFL] Add setting API to set a local storage database path. : [Attachment 67013] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Sep 14 18:35:22 PDT 2010


Gyuyoung Kim <gyuyoung.kim at samsung.com> has canceled Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 45446: [EFL] Add setting API to set a local storage database path.
https://bugs.webkit.org/show_bug.cgi?id=45446

Attachment 67013: Patch
https://bugs.webkit.org/attachment.cgi?id=67013&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
Antognolli, Thank you for your comment. 

I set default path from "priv->page_settings->localStorageDatabasePath()"

 40 +	 s = priv->page_settings->localStorageDatabasePath();
 41 +	 priv->settings.local_storage_database_path =
eina_stringshare_add(s.string().utf8().data());
 
As mentioned in your previous comment, the database path is null until user
sets database path. However, it seems to me that if the default path is set
once, default database path will be set whenever ewk_view is created.


More information about the webkit-reviews mailing list