[webkit-reviews] review granted: [Bug 45786] Make it possible to run more than one commit-queue instance : [Attachment 67615] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 45786: Make it possible to run more than one commit-queue instance
https://bugs.webkit.org/show_bug.cgi?id=45786

Attachment 67615: Patch
https://bugs.webkit.org/attachment.cgi?id=67615&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67615&action=prettypatch

> WebKitTools/QueueStatusServer/handlers/nextpatch.py:52
> +    def get(self, queue_name):
> +	   self.response.out.write(self._get_next_patch_id(queue_name))
We should use 404 if there's no next patch.  REST and all that.

> WebKitTools/Scripts/webkitpy/tool/commands/queues.py:156
> +    def _fetch_next_work_item(self):
> +	   self.tool.status_server.next_work_item(self.name)
No return?

> WebKitTools/Scripts/webkitpy/tool/commands/queues.py:219
> +	   log("Error: status server returned patch id %s which is not one I
sent to it.")
> +	   return None
Why is this an error?  It could have been put there by another instance of this
queue.