[webkit-reviews] review granted: [Bug 45785] Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef. : [Attachment 67614] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 45785: Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
https://bugs.webkit.org/show_bug.cgi?id=45785

Attachment 67614: Patch
https://bugs.webkit.org/attachment.cgi?id=67614&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
> Index: WebKitTools/ChangeLog
> ===================================================================
> --- WebKitTools/ChangeLog	(revision 67503)
> +++ WebKitTools/ChangeLog	(working copy)
> @@ -1,3 +1,28 @@
> +2010-09-14  Sam Weinig  <sam at webkit.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Remove WKBundleNodeRef, replacing uses with WKBundleNodeHandleRef.
> +	   https://bugs.webkit.org/show_bug.cgi?id=45785
> +
> +	   * MiniBrowser/mac/AppDelegate.m:
> +	   (-[BrowserAppDelegate init]):

I don't think you intended to add this.

> Index: WebKitTools/MiniBrowser/mac/AppDelegate.m
> ===================================================================
> --- WebKitTools/MiniBrowser/mac/AppDelegate.m (revision 67475)
> +++ WebKitTools/MiniBrowser/mac/AppDelegate.m (working copy)
> @@ -32,7 +32,7 @@
>  #import <WebKit2/WKStringCF.h>
>  #import <WebKit2/WKURLCF.h>
>  
> -static NSString *defaultURL = @"http://www.webkit.org/";
> +static NSString *defaultURL = @"http://www.tivofaq.com/";
>  
>  @implementation BrowserAppDelegate
>  
> @@ -113,10 +113,7 @@ - (id)init
>  {
>      self = [super init];
>      if (self) {
> -	   if ([NSEvent modifierFlags] & NSShiftKeyMask)
> -	       currentProcessModel = kProcessModelSharedSecondaryThread;
> -	   else
> -	       currentProcessModel = kProcessModelSharedSecondaryProcess;
> +	   currentProcessModel = kProcessModelSharedSecondaryThread;
>  
>	   WKContextRef threadContext = WKContextGetSharedThreadContext();
>	   WKContextHistoryClient historyClient = {

Or this. Looks fine otherwise!