[webkit-reviews] review requested: [Bug 43942] Textures and renderbuffers should be detached first before deletion if they are attached to framebuffers : [Attachment 67585] patch

[bugzilla-daemon at webkit.org]

Zhenyao Mo <zmo at google.com> has asked  for review:
Bug 43942: Textures and renderbuffers should be detached first before deletion
if they are attached to framebuffers
https://bugs.webkit.org/show_bug.cgi?id=43942

Attachment 67585: patch
https://bugs.webkit.org/attachment.cgi?id=67585&action=review

------- Additional Comments from Zhenyao Mo <zmo at google.com>
The test will be uploaded to khronos after review (I also sent it to
gman at google to review the test).

This patch fixes some bugs in object deletion behavior.  As for textures and
renderbuffers, we only remove the attachment from the currently-bound
framebuffer.  This will cause data inconsistency when we delete a texture/rbo
that's bound to a non-currently-bound fbo and later query the currently bound
object name of that fbo.  I guess we'll have to live with this bug.  At least
the buggy behavior will be the same for webgl and gles 2.