[webkit-reviews] review granted: [Bug 45759] Web Inspector: small refactoring for monitoringXHR flag. : [Attachment 67570] [patch] initial version. text version :).
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Sep 14 10:17:34 PDT 2010
Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 45759: Web Inspector: small refactoring for monitoringXHR flag.
https://bugs.webkit.org/show_bug.cgi?id=45759
Attachment 67570: [patch] initial version. text version :).
https://bugs.webkit.org/attachment.cgi?id=67570&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67570&action=prettypatch
> WebCore/inspector/InspectorController.cpp:-130
> -static const char* const monitoringXHRSettingName = "xhrMonitor";
Please make sure that it won't break existing clients.
> WebCore/inspector/InspectorController.cpp:251
> +String InspectorController::getBackendState()
The name sounds too general.
More information about the webkit-reviews
mailing list