[webkit-reviews] review granted: [Bug 8475] document.lastModified gives no output if the response doesn't have a Last-Modified header : [Attachment 67533] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 8475: document.lastModified gives no output if the response doesn't have a
Last-Modified header
https://bugs.webkit.org/show_bug.cgi?id=8475

Attachment 67533: Patch
https://bugs.webkit.org/attachment.cgi?id=67533&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67533&action=prettypatch

> WebCore/dom/Document.cpp:3623
> +    // FIXME: If this document came from the file system, HTML5 tells us to
> +    // read the last modification date from the file system.
I’m not sure HTML5 is the best colloquial name for the HTML specification.

> WebCore/dom/Document.cpp:3628
> +    return String::format("%02d/%02d/%04d %02d:%02d:%02d",
> +			     date.month()+1, date.monthDay(), date.fullYear(),
> +			     date.hour(), date.minute(), date.second());
We normally do not line subsequent lines up with parentheses like this.

We normally put spaces around operators like the "+" here in "+1".