[webkit-reviews] review granted: [Bug 39148] Handle <font size=0> as <font size=1> like any other browser : [Attachment 67520] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 39148: Handle <font size=0> as <font size=1> like any other browser
https://bugs.webkit.org/show_bug.cgi?id=39148

Attachment 67520: Patch
https://bugs.webkit.org/attachment.cgi?id=67520&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67520&action=prettypatch

Thanks for tackling this. Like other the many other HTML-specification-adoption
changes we are making these days, there is almost certainly going to be some
compatibility fallout in the future from content that has only ever been tested
with WebKit. So we should be on the lookout for those regressions.

> WebCore/html/HTMLFontElement.cpp:60
> +	   if (!isSpaceOrNewline(*position))
> +	       break;
WTF’s isSpaceOrNewline function is not correct to implement the HTML
specification’s “skip whitespace” algorithm. That is supposed to skip “space
characters” and the function isHTMLSpace in HTMLParserIdioms.h is the right one
for that. I’d like to see a test case or two covering that difference.

r=me but please use isHTMLSpace rather than isSpaceOrNewline.