[webkit-reviews] review requested: [Bug 41510] Add Base64DecodePolicy option at base64Decode() : [Attachment 67555] Patch

[bugzilla-daemon at webkit.org]

Patrick R. Gansterer <paroga at paroga.com> has asked  for review:
Bug 41510: Add Base64DecodePolicy option at base64Decode()
https://bugs.webkit.org/show_bug.cgi?id=41510

Attachment 67555: Patch
https://bugs.webkit.org/attachment.cgi?id=67555&action=review

------- Additional Comments from Patrick R. Gansterer <paroga at paroga.com>
The only change since the last patch is the following (+ChangeLog):
--- a/WebKit/mac/WebView/WebPreferences.mm
+++ b/WebKit/mac/WebView/WebPreferences.mm
@@ -642,7 +642,8 @@ (-[WebPreferences setUserStyleSheetLocation:])
	 locationString = [URL _web_originalDataAsString];
     }
     
-    [self _setStringValue:locationString forKey:
WebKitUserStyleSheetLocationPreferenceKey];
+    if (locationString)
+	 [self _setStringValue:locationString forKey:
WebKitUserStyleSheetLocationPreferenceKey];
 }
 
 - (BOOL)shouldPrintBackgrounds

This should avoid the crash:
*** Terminating app due to uncaught exception 'NSInvalidArgumentException',
reason: '*** -[NSCFDictionary setObject:forKey:]: attempt to insert nil value
(key: WebKitUserStyleSheetLocationPreferenceKey)'