[webkit-reviews] review requested: [Bug 45375] [Regression][Gtk] Left and Right Arrows no longer function when caret browsing is enabled : [Attachment 67538] Patch to fix this issue

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 45375: [Regression][Gtk] Left and Right Arrows no longer function when
caret browsing is enabled
https://bugs.webkit.org/show_bug.cgi?id=45375

Attachment 67538: Patch to fix this issue
https://bugs.webkit.org/attachment.cgi?id=67538&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Attaching patch that would fix this issue.

Basically it seems the problem was in how the Move[Word]{Forward|Backward}
commands were acting when the WebCore::Editor::Command::isEnabled()  function
was executed, that is, not taking into account whether caret browsing mode was
enabled or not, as it was done for the Move[Word]{Left|Command}. So, using the
enabledInEditableTextOrCaretBrowsing and enabledVisibleSelectionOrCaretBrowsing
for those commands (instead of just enabledInEditableText and
enabledVisibleSelection) would fix this issue.

Hence, now asking for review (and cq+ if approved) over this patch, which it's
prioritary stuff for a11y support as it's blocking some things on Orca, I think
(Joanmarie knows better about this)