[webkit-reviews] review granted: [Bug 45400] chromium/mac: let image layer data row order match skia : [Attachment 66934] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Nico Weber <thakis at chromium.org>'s
request for review:
Bug 45400: chromium/mac: let image layer data row order match skia
https://bugs.webkit.org/show_bug.cgi?id=45400

Attachment 66934: Patch
https://bugs.webkit.org/attachment.cgi?id=66934&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context:
https://bugs.webkit.org/attachment.cgi?id=66934&action=prettypatch

Thanks for cleaning this up. Would appreciate it if you could clean up two very
minor things before commit.

> WebCore/ChangeLog:20
> +	   (WebCore::ImageLayerChromium::updateContents):
Could you regenerate the ChangeLog? ImageLayerChromium.cpp isn't touched in the
diffs below.

> WebCore/platform/graphics/chromium/ContentLayerChromium.cpp:-87
> -	   "  vec4 texColor = texture2D(s_texture, vec2(v_texCoord.x, 1.0 -
v_texCoord.y)); \n"
Could you please clean up the comment at the top of the fragmentShaderString
too, in particular the reference to the differences in origin?