[webkit-reviews] review granted: [Bug 45706] SharedGraphicsContext3D's texture cache holds on to images after free : [Attachment 67467] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 45706: SharedGraphicsContext3D's texture cache holds on to images after
free
https://bugs.webkit.org/show_bug.cgi?id=45706

Attachment 67467: Patch
https://bugs.webkit.org/attachment.cgi?id=67467&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67467&action=prettypatch

Looks fine overall. Couple of minor comments.

> WebCore/ChangeLog:9
> +	   Whenever the backing native image is deleted it needs to let the
SharedGraphicsContext3D knows
knows -> know

> WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp:196
> +	    it != allContexts()->end(); ++it) {
This loop iteration should not be split across lines. No braces surrounding it.