[webkit-reviews] review granted: [Bug 45165] Expose Flags constructor if FileSystem API is Enabled : [Attachment 67159] Patch

[bugzilla-daemon at webkit.org]

Dumitru Daniliuc <dumi at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 45165: Expose Flags constructor if FileSystem API is Enabled
https://bugs.webkit.org/show_bug.cgi?id=45165

Attachment 67159: Patch
https://bugs.webkit.org/attachment.cgi?id=67159&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67159&action=prettypatch

r=me. please address the comment before landing.

> WebCore/bindings/scripts/CodeGeneratorV8.pm:3395
> +    if (length($signature->extendedAttributes->{"EnabledAtRuntime"}) > 1) {
to keep this function consistent with all other helper functions, i think we
should change its format to:

return "RuntimeEnabledFeatures::" .
$codeGenerator->WK_lcfirst($signature->extendedAttributes->{"EnabledAtRuntime"}
) . "Enabled" if ($signature->extendedAttributes->{"EnabledAtRuntime"} ne "");
return <the default name>;