[webkit-reviews] review granted: [Bug 44127] [chromium] Thumbnails not generated for GPU Rendered Pages : [Attachment 67419] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 44127: [chromium] Thumbnails not generated for GPU Rendered Pages
https://bugs.webkit.org/show_bug.cgi?id=44127

Attachment 67419: Patch
https://bugs.webkit.org/attachment.cgi?id=67419&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67419&action=prettypatch

> WebKit/chromium/src/WebViewImpl.cpp:980
> +    OwnPtr<ImageBuffer> imgBuffer(ImageBuffer::create(rect.size()));
nit: imgBuffer -> imageBuffer, imgData -> imageData

webkit style prefers spelling out variable names

> WebKit/chromium/src/WebViewImpl.cpp:1006
> +	       IntRect resizeRect(rect.x, rect.y, rect.width, rect.height);
nit: you can also just write:  IntRect resizeRect(rect);

there is an implicit conversion operator from WebRect to IntRect


R=me otherwise