[webkit-reviews] review requested: [Bug 45687] [GTK] Code simplification needed in Atk Wrapper : [Attachment 67433] Patch to fix this issue
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 13 11:09:07 PDT 2010
Mario Sanchez Prada <msanchez at igalia.com> has asked for review:
Bug 45687: [GTK] Code simplification needed in Atk Wrapper
https://bugs.webkit.org/show_bug.cgi?id=45687
Attachment 67433: Patch to fix this issue
https://bugs.webkit.org/attachment.cgi?id=67433&action=review
------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Attaching a patch to fix this "issue" by simplifying the code as expected:
Use TextIterator::rangeLength() to calculate endOffset
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(getSelectionOffsetsForObject): Don't manually iterate over a
artificial new range but just call TextIterator::rangeLength on
the range created between the start and end positions.
Hence, asking for review (and for the cq+ flag as well ;-)
More information about the webkit-reviews
mailing list