[webkit-reviews] review granted: [Bug 45644] Implement EOF handling in TextMode : [Attachment 67382] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 13 09:59:03 PDT 2010


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 45644: Implement EOF handling in TextMode
https://bugs.webkit.org/show_bug.cgi?id=45644

Attachment 67382: Patch
https://bugs.webkit.org/attachment.cgi?id=67382&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Oh, nm.  I see these are tied.

I guess I agree then.  We should remove this code and add it back with tests. 
It's possible to test this now that we have
layoutTestController.overridePreference().  We can use that in conjunction with
a platform/mac-leopard or mac-tiger test to test this code if it's truly
needed.


More information about the webkit-reviews mailing list