[webkit-reviews] review requested: [Bug 45651] jscPath() is incorrect in Windows' cmd.exe shell : [Attachment 67413] proposed fix

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has asked  for review:
Bug 45651: jscPath() is incorrect in Windows' cmd.exe shell
https://bugs.webkit.org/show_bug.cgi?id=45651

Attachment 67413: proposed fix
https://bugs.webkit.org/attachment.cgi?id=67413&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
proposed fix:
+    $jscName .= ".exe" if (isWindows() || isCygwin());

The root of the problem was that ' if -e "executableBinary" ' is false 
with ActiveState perl on Windows in cmd.exe shell, but true in CygWin 
shell if executableBinary.exe exist, but executableBinary doesn't.

It is a misleading perl feature what we should avoid, so I 
propose to add ".exe" suffix for Windows and CygWin platform too.