[webkit-reviews] review requested: [Bug 45673] Regression r65596 - Stack not 8 byte aligned : [Attachment 67411] Ensure ENABLE_PROFILER_REFERENCE_OFFSET is divisible by 8

[bugzilla-daemon at webkit.org]

David Tapuska <dtapuska at rim.com> has asked  for review:
Bug 45673: Regression r65596 - Stack not 8 byte aligned
https://bugs.webkit.org/show_bug.cgi?id=45673

Attachment 67411: Ensure ENABLE_PROFILER_REFERENCE_OFFSET is divisible by 8
https://bugs.webkit.org/attachment.cgi?id=67411&action=review

------- Additional Comments from David Tapuska <dtapuska at rim.com>
This change adjusts the padding in the struct. In r65596 the padding that was
there for JSVALUE32_64 was made useless because the object would be 8 byte
aligned already so it can be removed. The additional padding that was
essentially used for making sure the enabledProfilerReference offset was 8 byte
aligned for JSVALUE32 was moved ahead so that we remove this padding for
JSVALUE32_64 and have the correct field alignments for the rest. One benefit of
this change (aside from fixing the bug) is that it reduces the JITStackFrame by
12 bytes by removing useless padding.