[webkit-reviews] review denied: [Bug 45671] Web Inspector: provide support for opening external navigation for links within certain elements : [Attachment 67407] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 13 08:03:37 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has denied Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 45671: Web Inspector: provide support for opening external navigation for
links within certain elements
https://bugs.webkit.org/show_bug.cgi?id=45671

Attachment 67407: patch
https://bugs.webkit.org/attachment.cgi?id=67407&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
I'd much rather leave a single if (anchor.target === "_blank") check and would
manually create <a hrefs in extensions subsystem. Rationale:
WebInspector.linkify is too involved with resources panel.


More information about the webkit-reviews mailing list