[webkit-reviews] review granted: [Bug 45530] Web Inspector: Implement on-demand reporting of empty CSS rules matched for a node by WebCore : [Attachment 67186] [PATCH] Suggested solution

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 13 05:46:02 PDT 2010


Pavel Feldman <pfeldman at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 45530: Web Inspector: Implement on-demand reporting of empty CSS rules
matched for a node by WebCore
https://bugs.webkit.org/show_bug.cgi?id=45530

Attachment 67186: [PATCH] Suggested solution
https://bugs.webkit.org/attachment.cgi?id=67186&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>

> what do you think about includeEmptyRules name instead of debugMode?

I second this. When we add more relaxed properties we figure the new name out.
Rest looks good. r+ given rename takes place. Note that
(pseudo)styleRulesForElement is called from within DOMWindow API (that was
originally introduced for inspector) and from the markup. I wonder if they
should operate in relaxed mode by default.


More information about the webkit-reviews mailing list