[webkit-reviews] review denied: [Bug 45114] Web Inspector: show status message below call stack when debugger is paused : [Attachment 67388] Fix wording.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Pavel Podivilov
<podivilov at chromium.org>'s request for review:
Bug 45114: Web Inspector: show status message below call stack when debugger is
paused
https://bugs.webkit.org/show_bug.cgi?id=45114

Attachment 67388: Fix wording.
https://bugs.webkit.org/attachment.cgi?id=67388&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67388&action=prettypatch

Overall looks good.

> WebCore/inspector/front-end/CallStackSidebarPane.js:89
> +	   var breakpointOwnerLink =
WebInspector.panels.elements.linkifyNodeReference(breakpointOwnerNode);
breakpointOwnerNode can be undefined here.

> WebCore/inspector/front-end/CallStackSidebarPane.js:96
> +	       var targetNodeLink =
WebInspector.panels.elements.linkifyNodeReference(targetNode);
Ditto.

> WebCore/inspector/front-end/CallStackSidebarPane.js:99
> +		       format = WebInspector.UIString("Paused on a \"%s\"
breakpoint set on %s, because a new child was added to its descendant %s.");
Nit: I'd introduce WebInspector.formatLocalized beside UIString instead.