[webkit-reviews] review granted: [Bug 40768] Web Inspector: WebSocket in Resources tab : [Attachment 67379] Patch v9 (Update new test expectation)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 13 03:06:44 PDT 2010
Pavel Feldman <pfeldman at chromium.org> has granted Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 40768: Web Inspector: WebSocket in Resources tab
https://bugs.webkit.org/show_bug.cgi?id=40768
Attachment 67379: Patch v9 (Update new test expectation)
https://bugs.webkit.org/attachment.cgi?id=67379&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
This has been up in the air for too long, so let us land now. However, please
consider extracting web resource into a separate class to get rid of multiple
conditions and ifdefs. We probably should talk about how to approach it in a
way that would be consistent with the rest of the code.
More information about the webkit-reviews
mailing list