[webkit-reviews] review granted: [Bug 44201] Add common handling of viewport meta tag based on new Opera spec : [Attachment 66928] Patch (without non-ascii chars)

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 44201: Add common handling of viewport meta tag based on new Opera spec
https://bugs.webkit.org/show_bug.cgi?id=44201

Attachment 66928: Patch (without non-ascii chars)
https://bugs.webkit.org/attachment.cgi?id=66928&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
Looks good and well tested so r=me

It might be good to explain in comments where the magic constants come from
(the spec).

It is not entirely clear to me why the code dealing with available sizes can't
result in a division by zero as there is no obvious zero checking:

width = args.height * (availableWidth / availableHeight);
height = width * availableHeight / availableWidth;

Could you still double-check the logic?