[webkit-reviews] review requested: [Bug 45628] [WML] Fix a build break on R67355 when WML is enabled : [Attachment 67371] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 13 00:40:00 PDT 2010


Gyuyoung Kim <gyuyoung.kim at samsung.com> has asked  for review:
Bug 45628: [WML] Fix a build break on R67355 when WML is enabled
https://bugs.webkit.org/show_bug.cgi?id=45628

Attachment 67371: Patch
https://bugs.webkit.org/attachment.cgi?id=67371&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
Sorry for my poor expression in my patch. When wml is enabled, there are build
breaks as below, 

===============================================================================
=======================
/home/gyuyoung/webkit/WebKit-git/WebCore/wml/WMLAElement.cpp: In member
function ‘virtual void
WebCore::WMLAElement::defaultEventHandler(WebCore::Event*)’:
/home/gyuyoung/webkit/WebKit-git/WebCore/wml/WMLAElement.cpp:131: error: cannot
convert ‘WebCore::Document*’ to ‘WebCore::Event*’ for argument ‘1’ to ‘void
WebCore::handleLinkClick(WebCore::Event*, WebCore::Document*, const
WTF::String&, const WTF::String&, bool)’
/home/gyuyoung/webkit/WebKit-git/WebCore/wml/WMLInputElement.cpp: In member
function ‘virtual void
WebCore::WMLInputElement::defaultEventHandler(WebCore::Event*)’:
/home/gyuyoung/webkit/WebKit-git/WebCore/wml/WMLInputElement.cpp:277: error:
‘class WebCore::Frame’ has no member named ‘doTextFieldCommandFromEvent’
make[2]: *** [WebCore/CMakeFiles/webcore_efl.dir/wml/WMLAElement.cpp.o] Error 1

===============================================================================
=======================
So, I make a patch for this build breaks. I add more comments in Changelog. :) 


Thank you.


More information about the webkit-reviews mailing list