[webkit-reviews] review granted: [Bug 45638] Move mixed content logic out of FrameLoader : [Attachment 67366] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 45638: Move mixed content logic out of FrameLoader
https://bugs.webkit.org/show_bug.cgi?id=45638

Attachment 67366: Patch
https://bugs.webkit.org/attachment.cgi?id=67366&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67366&action=prettypatch

> WebCore/loader/MixedContentChecker.cpp:63
> +inline CString asUTF8(const KURL& url)
> +{
> +    return url.string().utf8();
> +}
static?

> WebCore/loader/MixedContentChecker.cpp:65
> +void MixedContentChecker::checkIfDisplayInsecureContent(SecurityOrigin*
context, const KURL& url) const
We usually call SecurityOrigin objects securityOrigin.	Usually "context"
refers to a ScriptExecutionContext.

> WebCore/loader/MixedContentChecker.h:49
> +    void checkIfDisplayInsecureContent(SecurityOrigin* context, const KURL&)
const;
> +    void checkIfRunInsecureContent(SecurityOrigin* context, const KURL&)
const;
The parameter name for SecurityOrigin isn't needed here.