[webkit-reviews] review denied: [Bug 45572] WebAccessibilityCacheImpl needs to handle invalid accessibility object ids : [Attachment 67285] Passes style check now

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has denied chris.guillory at google.com's
request for review:
Bug 45572: WebAccessibilityCacheImpl needs to handle invalid accessibility
object ids
https://bugs.webkit.org/show_bug.cgi?id=45572

Attachment 67285: Passes style check now
https://bugs.webkit.org/attachment.cgi?id=67285&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
> Index: WebKit/chromium/ChangeLog
> ===================================================================
> --- WebKit/chromium/ChangeLog (revision 67263)
> +++ WebKit/chromium/ChangeLog (working copy)
> @@ -1,3 +1,16 @@
> +2010-09-10  Chris Guillory  <chris.guillory at google.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   WebAccessibilityCacheImpl needs to handle invalid accessibility
object ids

period at end of sentence
> +    WEBKIT_API bool isAxObjectIdValid() const;

since this is inside of an ax object, the method name should probably just be
"isIdValid()"

>  
>      WEBKIT_API unsigned childCount() const;
>  
> +bool WebAccessibilityObject::isAxObjectIdValid() const
> +{
> +    if (!m_private)
> +	   return false;
> +
> +    m_private->updateBackingStore();

after calling updateBackingStore() it's possible that m_private will be
invalidated (on the WebCore side at least, where it's called m_object). 
you should probably confirm that the object is still valid after calling this
method

> +    return m_private->axObjectID();
> +}
> +