[webkit-reviews] review denied: [Bug 41465] [Qt] QtWebKit should have documentation clarifying its mobile features usage : [Attachment 62768] Documentation

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Jesus
Sanchez-Palencia <jesus at webkit.org>'s request for review:
Bug 41465: [Qt] QtWebKit should have documentation clarifying its mobile
features usage
https://bugs.webkit.org/show_bug.cgi?id=41465

Attachment 62768: Documentation
https://bugs.webkit.org/attachment.cgi?id=62768&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=62768&action=prettypatch

> WebKit/qt/docs/qtwebkit-goes-mobile.qdoc:12
> +    Among tons of bug fixes and good performance improvements there are also

> +    lots of new features being developed, mainly geared toward mobile
deployment.
Maybe these lines are not relevant?

> WebKit/qt/docs/qtwebkit-goes-mobile.qdoc:74
> +    More information about Tiling can be found here:
\l{http://doc.qt.nokia.com/4.7-snapshot/qwebsettings.html#WebAttribute-enum}
(see the entry for TiledBackingStoreEnabled)
I think this should be done differently to link inside the documentation

> WebKit/qt/docs/qtwebkit-goes-mobile.qdoc:100
> +    Qt 4.7 docs also says: \e{"This property should be used in conjunction
with
> +    the QWebPage::preferredContentsSize property. If not explicitly set, the

> +    preferredContentsSize is automatically set to a reasonable value."}
we probably should refer to Qt 4.7

> WebKit/qt/docs/qtwebkit-goes-mobile.qdoc:172
> +    You must connect the signal \c{QWebPage::viewportChangeRequested(const
> +    QWebPage::ViewportHints& hints)} to a slot of your mobile web view and
use what
> +    is provided by \l{QWebPage::ViewportHints} to update your viewport size,
scale
> +    range, and so on.
We are about to change the above API, please check the relevant bug