[webkit-reviews] review granted: [Bug 45604] Add callback mechanism for the getting the source of a frame : [Attachment 67321] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Sep 11 18:13:16 PDT 2010
mitz at webkit.org has granted Sam Weinig <sam at webkit.org>'s request for review:
Bug 45604: Add callback mechanism for the getting the source of a frame
https://bugs.webkit.org/show_bug.cgi?id=45604
Attachment 67321: Patch
https://bugs.webkit.org/attachment.cgi?id=67321&action=review
------- Additional Comments from mitz at webkit.org
View in context:
https://bugs.webkit.org/attachment.cgi?id=67321&action=prettypatch
> WebKit2/UIProcess/WebPageProxy.cpp:1177
> + Vector<RefPtr<FrameSourceCallback> > frameSourceCallbacks;
> + copyValuesToVector(m_frameSourceCallbacks, frameSourceCallbacks);
> + m_frameSourceCallbacks.clear();
> + for (size_t i = 0, size = frameSourceCallbacks.size(); i < size; ++i)
> + frameSourceCallbacks[i]->invalidate();
> +
Consider factoring common code out of processDidExit() and close().
> WebKit2/UIProcess/WebPageProxy.h:82
> typedef GenericCallback<WKStringRef, WTF::StringImpl*>
RenderTreeExternalRepresentationCallback;
> typedef GenericCallback<WKStringRef, WTF::StringImpl*>
ScriptReturnValueCallback;
> +typedef GenericCallback<WKStringRef, WTF::StringImpl*> FrameSourceCallback;
>
Maybe keep these sorted?
> WebKit2/UIProcess/WebPageProxy.h:243
>
> void didReceiveEvent(WebEvent::Type);
> +
> void didRunJavaScriptInMainFrame(const WTF::String&, uint64_t);
Why the new newline?
More information about the webkit-reviews
mailing list