[webkit-reviews] review granted: [Bug 45522] Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom. : [Attachment 67275] Patch 3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 10 18:14:59 PDT 2010


Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 45522: Remove unnecessary constraint in WebCore of choosing either text
zoom or full page zoom.
https://bugs.webkit.org/show_bug.cgi?id=45522

Attachment 67275: Patch 3
https://bugs.webkit.org/attachment.cgi?id=67275&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    float textZoomFactor() const  { return m_textZoomFactor; }

Extra space here after const.

Longer term you should find a way to make it efficient to set both zoom factors
separately, presumably by making sure the style recalculation is deferred, and
eliminate the function to do both at once.

r=me


More information about the webkit-reviews mailing list