[webkit-reviews] review denied: [Bug 45522] Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom. : [Attachment 67229] Updated patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Sam Weinig
<sam at webkit.org>'s request for review:
Bug 45522: Remove unnecessary constraint in WebCore of choosing either text
zoom or full page zoom.
https://bugs.webkit.org/show_bug.cgi?id=45522

Attachment 67229: Updated patch
https://bugs.webkit.org/attachment.cgi?id=67229&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67229&action=prettypatch

> WebKit/chromium/src/WebViewImpl.cpp:1489
> +    if (oldZoomFactor != zoomFactor && textOnly != m_zoomTextOnly) {
shouldn't this be an OR?  if either the zoom factor or the textOnly flag
changes, we need to notify the plugin.