[webkit-reviews] review denied: [Bug 44709] deduplicate-tests should be runnable from any WebKit directory : [Attachment 67245] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 10 15:15:20 PDT 2010


Eric Seidel <eric at webkit.org> has denied Tony Chang <tony at chromium.org>'s
request for review:
Bug 44709: deduplicate-tests should be runnable from any WebKit directory
https://bugs.webkit.org/show_bug.cgi?id=44709

Attachment 67245: Patch
https://bugs.webkit.org/attachment.cgi?id=67245&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This seems wrong.

Did you just want this?
http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/system
/ospath.py

Why not use absolute paths?

See how scm.py solves the run-from-anywhere problem by passing a cwd to
executive.py:

http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/checko
ut/scm.py


More information about the webkit-reviews mailing list