[webkit-reviews] review granted: [Bug 22382] Middle click fires onclick event : [Attachment 67225] patch, cleanup portion, v1.1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Peter Kasting <pkasting at google.com>'s
request for review:
Bug 22382: Middle click fires onclick event
https://bugs.webkit.org/show_bug.cgi?id=22382

Attachment 67225: patch, cleanup portion, v1.1
https://bugs.webkit.org/attachment.cgi?id=67225&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    return isLink() ?
treatLinkAsLiveForEventType(m_wasShiftKeyDownOnMouseDown ?
MouseEventWithShiftKey : MouseEventWithoutShiftKey) : false;

I think that && would be clearer here than ? : false.

> +    static EventType eventTypeFromEvent(Event*);

I don’t think this function’s name needs the “FromEvent” suffix.

> +	       String target(isMiddleMouseButtonEvent(event) ? "_blank" :
this->target());

I think this would read more clearly with "=" than with construction-style
syntax.

> +	       // FIXME: It's not clear why setting target to "_self" is ever
> +	       // helpful.

This comment would be better if it was one line instead of two.

r=me