[webkit-reviews] review granted: [Bug 45494] Paste should be implemented in WebCore like Copy and Cut for Mac also : [Attachment 67111] Patch2

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Enrica Casucci <enrica at apple.com>'s
request for review:
Bug 45494: Paste should be implemented in WebCore like Copy and Cut for Mac
also
https://bugs.webkit.org/show_bug.cgi?id=45494

Attachment 67111: Patch2
https://bugs.webkit.org/attachment.cgi?id=67111&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context:
https://bugs.webkit.org/attachment.cgi?id=67111&action=prettypatch

> WebCore/loader/FrameLoaderClient.h:209
> +#if PLATFORM(MAC)
> +	   virtual bool canShowMIMETypeAsHTML(const String& MIMEType) const =
0;
> +#endif
This doesn't have to be mac specific.

> WebCore/page/EditorClient.h:156
> +    virtual DocumentFragment*
documentFromAttributedString(NSAttributedString*, Vector<ArchiveResource*>&) =
0;
This should probably be called documentFragmentFromAttributedString.

> WebCore/platform/mac/PasteboardMac.mm:441
> +PassRefPtr<DocumentFragment>
Pasteboard::documentFragmentFromPasteboard(Frame* frame, PassRefPtr<Range>
context, bool allowPlainText)
> +{
I think this function should be merged into Pasteboard::documentFragment.


r+ with this changes.