[webkit-reviews] review requested: [Bug 45522] Remove unnecessary constraint in WebCore of choosing either text zoom or full page zoom. : [Attachment 67229] Updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 10 13:50:38 PDT 2010


Sam Weinig <sam at webkit.org> has asked  for review:
Bug 45522: Remove unnecessary constraint in WebCore of choosing either text
zoom or full page zoom.
https://bugs.webkit.org/show_bug.cgi?id=45522

Attachment 67229: Updated patch
https://bugs.webkit.org/attachment.cgi?id=67229&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
Thanks for the feedback. Here is an updated patch. It turns out the call to
setNeedsRecalcStyleInAllFrames was unnecessary and that we would probably end
up doing a little too much work if we called both setPageZoomFactor and
setTextZoomFactor in a row, so I have added a function which can change both at
once if that is what is wanted.


More information about the webkit-reviews mailing list